quadlet: support tarball extraction for install command#28136
quadlet: support tarball extraction for install command#28136Veector40 wants to merge 1 commit intocontainers:mainfrom
Conversation
There was a problem hiding this comment.
Thanks for the contribution! I have a few suggestions for improvement. We might want to consider avoiding staging everything in a temporary directory. Instead, we could stream entries from the tarball directly to a reader based variant of installQuadlet. This is a bit outside the scope of the original issue, but it's worth considering during this refactor.
23213d6 to
3922957
Compare
|
Thanks for the great feedback, @Honny1! I've updated the PR to address your suggestions:
Let me know if you'd like anything else to be amended |
|
Before I do a second round of review, please ensure the CI passes. |
3922957 to
cdb8754
Compare
Currently, podman quadlet install only supports individual files or directories. This implements support for installing Quadlet applications packaged as tar archives. Changes: - Detects .tar, .tar.gz, and .tgz files. - Uses go.podman.io/storage/pkg/archive for robust extraction. - Unifies URL and local path handling. - Groups extracted units under a single .app asset for easy tracking/removal. Fixes: containers#28117 Signed-off-by: Victor Koycheff <victorkoycheff@gmail.com>
cdb8754 to
b0f9839
Compare
|
Hey @Veector40 I'm the author of the issue you are trying to solve (#28117). It has been a week, and I was wondering if you are still planning to work on this issue? Otherwise I'm interested in taking over the issue 👍 |
|
Ofc, it's all yours. In case you need a review or anything, let me know |
|
A friendly reminder that this PR had no activity for 30 days. |
Currently,
podman quadlet installonly supports individual files or directories. This PR implements support for installing Quadlet applications packaged as tar archives, satisfying a recent feature request.Changes:
.tar,.tar.gz, and.tgzfiles for both local paths and remote HTTP/HTTPS URLs..appasset file for easy management and removal.253-podman-quadlet.batsthat verifies both standard and compressed tarball installation, listing, and clean removal.Fixes: #28117
Checklist
Fixes: #28117in commit message.make validatepr(format/lint checks).Does this PR introduce a user-facing change?