Conversation
Newer runtime tools separates syscalls by OS so we can build darwin. Signed-off-by: baude <bbaude@redhat.com>
Signed-off-by: baude <bbaude@redhat.com>
|
LGTM |
baude
force-pushed
the
vendorruntimetools
branch
from
469ac8a to
efd1b16
Compare
|
bot, retest this please |
|
LGTM pending tests |
pkg/spec/spec.go
Outdated
There was a problem hiding this comment.
The rest of CreateConfigToOCISpec is pretty Linux-specific, so I'm fine with this being hard-coded here. But CreateConfigToOCISpec is so opinionated, I'm surprised you need to seed it at all. Do you know what parts of this initial config survive the subsequent edits to be returned to the caller? You might just want to build the *spec.Spec object directly.
|
LGTM, but tests are unhappy |
Signed-off-by: baude <bbaude@redhat.com>
baude
force-pushed
the
vendorruntimetools
branch
from
efd1b16 to
1110e73
Compare
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ctr.config.Spec = g.Spec() |
There was a problem hiding this comment.
This should have g.Spec() -> g.Config (and similarly in CreateConfigToOCISpec).
There was a problem hiding this comment.
This should have
g.Spec()->g.Config(and similarly inCreateConfigToOCISpec).
I've filed #1008 for this.
|
📌 Commit 1110e73 has been approved by |
|
⚡ Test exempted: merge already tested. |
Signed-off-by: baude <bbaude@redhat.com> Closes: #1007 Approved by: baude
Signed-off-by: baude <bbaude@redhat.com> Closes: #1007 Approved by: baude
Catching up with opencontainers/runtime-tools@84a62c6a (generate: Move Generator.spec to Generator.Config, 2016-11-06, containers#266, v0.6.0), now that we've bumped runtime-tools in f6c0fc1 (Vendor in latest runtime-tools, 2018-06-26, containers#1007). Signed-off-by: W. Trevor King <wking@tremily.us>
Catching up with opencontainers/runtime-tools@84a62c6a (generate: Move Generator.spec to Generator.Config, 2016-11-06, #266, v0.6.0), now that we've bumped runtime-tools in f6c0fc1 (Vendor in latest runtime-tools, 2018-06-26, #1007). Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #1008 Approved by: mheon
github-actions
bot
added
the
locked - please file new issue/PR
6 participants
Update runtime-tools and buildah to account for the the generator functions and Darwin compilability.