Conversation
1ff6444 to
441f6d6
Compare
| url: https://github.com/containers/podman-py | ||
| ref: "v5.7.0" |
There was a problem hiding this comment.
adding a comment for reviewers and myself of the future
this is needed from Fedora side to pull tests and run gating in fedora PRs
https://src.fedoraproject.org/rpms/python-podman/pull-request/57#request_diff
441f6d6 to
b10faac
Compare
b10faac to
fbf9bc2
Compare
Honny1
left a comment
There was a problem hiding this comment.
I have one nit. Otherwise, LGTM! We just need to test it and probably address any potential issues.
| exit 1 | ||
| fi | ||
|
|
||
| # Update: |
There was a problem hiding this comment.
Non-blocking: Should be solved as a follow-up pr.
This script updates 6 files, but pyproject.toml already has TODOs to enable dynamic versioning from podman/version.py:
# TODO: remove the line version = ... on podman-py > 5.4.0 releases
# dynamic = ["version"]
# version = {attr = "podman.version.__version__"}And the Makefile could derive the version at build time instead of hardcoding it.
Resolving this tech debt first would reduce the script to only updating 3 files (podman/version.py, podman/tests/__init__.py, plans/main.fmf) and make the release automation simpler and less fragile.
There was a problem hiding this comment.
@Honny1 addressed the debt in makefile too
This is a first step that makes the foundations for future work. Ideally we'd like to create this automatically when podman publishes a release, but for now it's ok to have a manual workflow trigger Signed-off-by: Nicola Sella <nsella@redhat.com>
fbf9bc2 to
c0159aa
Compare
|
/packit retest-failed |
|
@Honny1 ptal |
Honny1
left a comment
There was a problem hiding this comment.
LGTM. One small note: the PyPI release is triggered by pushing the tag, not by publishing the GitHub release. Is this good?
|
mmmh, maybe we could change the PyPI release to run on GH release. I think the one that's in the python guides uses the tag and I didn't change it |
|
LGTM |
This is a first step that makes the foundations for future work. Ideally we'd like to create this automatically when podman publishes a release.
At this state, ideally, the workflow will be done in 3 manual steps.
This is just an idea. Input is greatly appreciated.