Skip to content

Add release PR workflow#627

Merged
Honny1 merged 1 commit intocontainers:mainfrom
inknos:automate-releases
Mar 24, 2026
Merged

Add release PR workflow#627
Honny1 merged 1 commit intocontainers:mainfrom
inknos:automate-releases

Conversation

@inknos
Copy link
Copy Markdown
Contributor

@inknos inknos commented Feb 5, 2026

This is a first step that makes the foundations for future work. Ideally we'd like to create this automatically when podman publishes a release.

At this state, ideally, the workflow will be done in 3 manual steps.

  1. Triggering a workflow by specifying a version number. This it will create a PR with all the necessary changes and run all the tests.
  2. Manual merge: after that another action will create and push a git tag and publish a draft release.
  3. Publish the release is the final manual action. After publishing, a packit and PyPI releases are triggered automatically.

This is just an idea. Input is greatly appreciated.

Comment thread plans/main.fmf
Comment on lines +5 to +6
url: https://github.com/containers/podman-py
ref: "v5.7.0"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a comment for reviewers and myself of the future
this is needed from Fedora side to pull tests and run gating in fedora PRs
https://src.fedoraproject.org/rpms/python-podman/pull-request/57#request_diff

@inknos inknos force-pushed the automate-releases branch from 441f6d6 to b10faac Compare February 5, 2026 17:38
@inknos inknos force-pushed the automate-releases branch from b10faac to fbf9bc2 Compare March 19, 2026 15:51
@inknos inknos marked this pull request as ready for review March 19, 2026 15:53
@inknos inknos changed the title [wip] Add release PR workflow Add release PR workflow Mar 19, 2026
Copy link
Copy Markdown
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one nit. Otherwise, LGTM! We just need to test it and probably address any potential issues.

Comment thread .github/workflows/create-release-pr.yml Outdated
exit 1
fi

# Update:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Should be solved as a follow-up pr.

This script updates 6 files, but pyproject.toml already has TODOs to enable dynamic versioning from podman/version.py:

# TODO: remove the line version = ... on podman-py > 5.4.0 releases
# dynamic = ["version"]
# version = {attr = "podman.version.__version__"}

And the Makefile could derive the version at build time instead of hardcoding it.

Resolving this tech debt first would reduce the script to only updating 3 files (podman/version.py, podman/tests/__init__.py, plans/main.fmf) and make the release automation simpler and less fragile.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Honny1 addressed the debt in makefile too

This is a first step that makes the foundations for future work.
Ideally we'd like to create this automatically when podman publishes a
release, but for now it's ok to have a manual workflow trigger

Signed-off-by: Nicola Sella <nsella@redhat.com>
@inknos
Copy link
Copy Markdown
Contributor Author

inknos commented Mar 20, 2026

/packit retest-failed

@inknos
Copy link
Copy Markdown
Contributor Author

inknos commented Mar 20, 2026

@Honny1 ptal

Copy link
Copy Markdown
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small note: the PyPI release is triggered by pushing the tag, not by publishing the GitHub release. Is this good?

@inknos
Copy link
Copy Markdown
Contributor Author

inknos commented Mar 20, 2026

mmmh, maybe we could change the PyPI release to run on GH release. I think the one that's in the python guides uses the tag and I didn't change it

@Honny1
Copy link
Copy Markdown
Member

Honny1 commented Mar 24, 2026

LGTM

@Honny1 Honny1 merged commit dbbaee4 into containers:main Mar 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants