Fix pytest flag for rootful test#623
Merged
inknos merged 1 commit intocontainers:mainfrom Feb 18, 2026
Merged
Conversation
Contributor
Author
|
/packit retest-failed |
Contributor
Author
|
/packit rebuild-failed |
Honny1
reviewed
Feb 16, 2026
| f"size={mount['size']},rprivate,nosuid,nodev,tmpcopyup", | ||
| ) | ||
|
|
||
| @pytest.mark.skipif(os.geteuid() != 0, reason='Skipping, not running as root') |
Member
There was a problem hiding this comment.
I'm a little confused by the reason text and the PR description. Should it be reason="Skipping, rootless user"?
Non-blocking:
I would also suggest creating a helper function:
def is_root():
return os.geteuid() == 0This would be more readable and could be reused in other cases if needed.
Contributor
Author
There was a problem hiding this comment.
I think I had twisted brain cells at the time of writing. also, your comment made sense so I implemented the helper, and finally, I changed commit message an fixed the reasons. Now it should be better
Signed-off-by: Nicola Sella <nsella@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a test that needs to be run if root only