check include block data type #1331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if include is of type dict or list, throw error if it is dict but 'path' is not the key Fixes containers#1320 Signed-off-by: Anton Petrov <antonpetrov145@yahoo.com>
p12tic
reviewed
Nov 29, 2025
podman_compose.py
Outdated
|
|
||
| @overload | ||
| def try_int(i: int | str, fallback: int) -> int: ... | ||
| def try_int(i: int | str, fallback: int) -> int: |
Collaborator
There was a problem hiding this comment.
Please revert formatting changes, ruff format will not like this.
Author
There was a problem hiding this comment.
it was because of pre-commit errors
podman_compose.py:65:1: E704 multiple statements on one line (def)
podman_compose.py:69:1: E704 multiple statements on one line (def)
podman_compose.py:276:1: E704 multiple statements on one line (def)
podman_compose.py:280:1: E704 multiple statements on one line (def)
podman_compose.py:284:1: E704 multiple statements on one line (def)
reverted
p12tic
reviewed
Nov 29, 2025
| if include: | ||
| files.extend([os.path.join(os.path.dirname(filename), i) for i in include]) | ||
| # Check if 'include' block is dict or list of strings | ||
| for i in include: |
Collaborator
There was a problem hiding this comment.
Please add unit or integration test.
Author
There was a problem hiding this comment.
extended the include test that is in project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if include is of type dict or list, throw error if it is dict but 'path' is not the key
Fixes #1320
Signed-off-by: Anton Petrov antonpetrov145@yahoo.com