fix failed recognition of custom containerfile due to Windows paths (e.g C:\some\path) being misinterpreted as git urls#1286
fix failed recognition of custom containerfile due to Windows paths (e.g C:\some\path) being misinterpreted as git urls#1286metroite wants to merge 1 commit intocontainers:mainfrom
C:\some\path) being misinterpreted as git urls#1286Conversation
metroite
changed the title
metroite
changed the title
metroite
force-pushed
the
main
branch
2 times, most recently
from
b2e2526 to
3145b02
Compare
metroite
changed the title
C:\some\path) being misinterpreted as git urls
|
@metroite Seems that the PR does not contain any changes. |
…eing misinterpreted as git urls Signed-off-by: Metroite <22453965+Metroite@users.noreply.github.com>
metroite
force-pushed
the
main
branch
2 times, most recently
from
d5be817 to
cdf553f
Compare
Thank you. I don't know how that happened, but thats probably due to the now roughly 50 force pushes for 3 lines of code. LGTM |
|
@p12tic Can you merge this or implement a proper fix? It is very annoying when your project doesn't work on Windows environments. Also this improves parity with docker-compose. |
|
Can confirm that this fixes the issue on my machine. Would be nice to have this merged so I don't have to maintain a modified version on my local machine. |
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Sorry for taking this long for review.
Please add release note in newsfragments directory. Also this change needs unit test. Feel free to mock os.name to execute this code path.
3 participants
Link to docker-compose spec.
See minimal example (works with docker compose, not with podman).
This error occurs when trying to run any podman-compose.yml with a build
context:anddockerfile:directive:There is a line in
is_context_git_url()which checks for a:in the context path. As Windows uses:to seperate drives, this results in a bad assertion of every Windows path as a git context.