fix: reject auto-generated gateways outside subnets#1447
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
Luap99
reviewed
May 11, 2026
Comment on lines
+161
to
166
| if !network.contains(&first_ip) { | ||
| return Err(NetavarkError::msg(format!( | ||
| "could not create gateway for subnet {}", | ||
| network | ||
| ))); | ||
| } |
Member
There was a problem hiding this comment.
instead of adding another check here could you not just swap the order in validate_subnet() which already checks that as well.
Then again if we do not work with /32 or /128 then we might as well produce an actual error saying that explicitly at least.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for create validation.
Before this,
/32and/128subnets with no gateway slipped thru. Netavark generatednetwork + 1, which is outside the subnet. Tiny footgun, tbh.Repro:
PROTOC=/tmp/netavark-protoc/bin/protoc cargo test validate_subnet_rejects_ --libvalidate_subnet()returnsOk(())for10.100.0.1/32andfd00::1/128Now
first_ip_in_subnet()checks the generated gateway is still inside the subnet and errors cleanly when it is not.Tests:
PROTOC=/tmp/netavark-protoc/bin/protoc cargo test --lib