tests/virtiofs-misc: add rename-overwrite fchmod subtest#705
Open
slp wants to merge 1 commit into
Open
Conversation
slp
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
Add regression test for PR containers#700, which fixed a file descriptor leak on macOS when renaming over an existing file with open fds. The bug: macOS virtio-fs uses volfs paths (/.vol/{dev}/{ino}) which become invalid when the inode's last link is removed. When rename() replaces a file, the old target loses its directory entry, breaking subsequent operations on still-open file descriptors. This broke apt/dpkg atomic writes with errors like: "Problem closing the file /var/lib/dpkg/status - close (2: No such file or directory)" The fix stores an fd to the doomed target before rename, preserving access to the unlinked inode for tracked fds. The test verifies that fchmod() works on an open fd after the file has been atomically replaced via rename. Assisted-by: Claude Code:claude-opus-4.6 Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
force-pushed
the
virtiofs-rename-overwrite-tests
branch
from
9264d08 to
85efa04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression test for PR #700, which fixed a file descriptor leak on macOS when renaming over an existing file with open fds.
The bug: macOS virtio-fs uses volfs paths (/.vol/{dev}/{ino}) which become invalid when the inode's last link is removed. When rename() replaces a file, the old target loses its directory entry, breaking subsequent operations on still-open file descriptors.
This broke apt/dpkg atomic writes with errors like: "Problem closing the file /var/lib/dpkg/status - close (2: No such file or directory)"
The fix stores an fd to the doomed target before rename, preserving access to the unlinked inode for tracked fds.
The test verifies that fchmod() works on an open fd after the file has been atomically replaced via rename.
Assisted-by: Claude Code:claude-opus-4.6