Merged
Conversation
This was referenced Mar 4, 2017
Member
|
LGTM |
Collaborator
Author
|
@aweiteka @mhrivnak (@puiterwijk) PTAL. E.g. for [ |
|
This looks good to me. |
aweiteka
approved these changes
Mar 6, 2017
mtrmac
force-pushed
the
change-sigstore-layout
branch
from
8c2c1df to
9984b0a
Compare
mtrmac
force-pushed
the
change-sigstore-layout
branch
2 times, most recently
from
86f250a to
05dfbab
Compare
i.e. use …/busybox@sha256=… instead of ../busybox@sha256:… . See containers#187 for more discussion. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
See a long meandering discussion in containers#120 . Note that the repo name within a single host is still used within the signstore path, only the host name has been dropped. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
change-sigstore-layout
branch
from
05dfbab to
ec116a0
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
=instead of:, to avoid a Windows reserved character. Fixes Docker signature transport uses reserved URI characters #187 .