Skip to content

Conversation

@kolyshkin
Copy link
Collaborator

We don't really need to run Fedora container in order to execute codespell. Inspired by a recent dockerhub reject.

Notes:

  • we use pip so we don't depend on whatever version is installed on the host (Ubuntu);
  • since Ubuntu 24.04, --break-system-packages is required;
  • we use a specified version to avoid unexpected CI failures caused by newer codespell.

While at it, remove an exclusion from .codespellrc -- apparently no longer needed.

We don't really need to run Fedora container in order to execute
codespell. Inspired by a recent dockerhub reject.

Notes:
 - we use pip so we don't depend on whatever version is installed on the
   host (Ubuntu);
 - since Ubuntu 24.04, --break-system-packages is required;
 - we use a specified version to avoid unexpected CI failures caused by
   newer codespell.

While at it, remove an exclusion from .codespellrc -- apparently no
longer needed.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @kolyshkin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the continuous integration process for codespell checks. It refactors the CI job to eliminate the need for a dedicated Fedora container, opting instead for a more direct pip-based installation of codespell. This change aims to enhance the efficiency and reliability of the spell-checking workflow, reducing potential CI failures and simplifying maintenance.

Highlights

  • CI Job Simplification: The codespell CI job has been simplified by removing the dependency on a Fedora container, making it more lightweight and resilient.
  • Dependency Management: codespell is now installed via pip with a specified version, ensuring consistent behavior across different CI environments and avoiding system package conflicts.
  • Codespell Configuration: The trun entry was removed from the .codespellrc ignore list, as it is no longer deemed necessary.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .codespellrc
    • Removed "trun" from the ignore-words-list.
  • tests/codespell/Dockerfile
    • Removed the Dockerfile that defined the Fedora-based codespell environment.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/test.yaml
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively simplifies the codespell CI job by removing the dependency on a custom Fedora Docker container, which should improve CI performance and maintainability. The rationale for the changes, including the move to a pip-based installation and the cleanup of the .codespellrc file, is clear and sound. The changes look good.

@packit-as-a-service
Copy link

TMT tests failed. @containers/packit-build please check.

@kolyshkin
Copy link
Collaborator Author

Test (podman) is broken; the fix is containers/podman#28088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant