-
Notifications
You must be signed in to change notification settings - Fork 388
ci: simplify codespell job #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We don't really need to run Fedora container in order to execute codespell. Inspired by a recent dockerhub reject. Notes: - we use pip so we don't depend on whatever version is installed on the host (Ubuntu); - since Ubuntu 24.04, --break-system-packages is required; - we use a specified version to avoid unexpected CI failures caused by newer codespell. While at it, remove an exclusion from .codespellrc -- apparently no longer needed. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Summary of ChangesHello @kolyshkin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the continuous integration process for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively simplifies the codespell CI job by removing the dependency on a custom Fedora Docker container, which should improve CI performance and maintainability. The rationale for the changes, including the move to a pip-based installation and the cleanup of the .codespellrc file, is clear and sound. The changes look good.
|
TMT tests failed. @containers/packit-build please check. |
|
Test (podman) is broken; the fix is containers/podman#28088 |
We don't really need to run Fedora container in order to execute codespell. Inspired by a recent dockerhub reject.
Notes:
While at it, remove an exclusion from .codespellrc -- apparently no longer needed.