-
Notifications
You must be signed in to change notification settings - Fork 388
ci: tests/podman: exclude ever failing test case #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The test case named > podman build and remove basic alpine with TMPDIR as relative always fails here because we're running it inside docker using overlayfs, and TMPDIR="." set by test results in overlay upperdir being on overlayfs. Since nested overlayfs is not supported, the mount fails: > overlay: filesystem on ..../upper not supported as upperdir Since the test case is always failing and is not really testing any specific crun aspect, let's skip it. This should bring Test (podman) back to green. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Summary of ChangesHello @kolyshkin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a persistent CI failure by excluding a specific Podman build test case. The test, which involves building an Alpine image with a relative temporary directory, consistently fails when run inside a Docker container due to an incompatibility with nested OverlayFS. By skipping this non-critical test for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly excludes a persistently failing test case by adding it to the --skip list in the ginkgo command. The change is justified by the environment limitations explained in the description. I've added one minor suggestion to correct a potential typo in an issue number reference within a comment.
|
TMT tests failed. @containers/packit-build please check. |
giuseppe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test case named
always fails here because we're running it inside docker using overlayfs, and TMPDIR="." set by test results in overlay upperdir being on overlayfs. Since nested overlayfs is not supported, the mount fails:
Since the test case is always failing and is not really testing any specific crun aspect, let's skip it.
This should bring Test (podman) back to green.
Fixes: #1999