Skip to content

Conversation

@kolyshkin
Copy link
Collaborator

@kolyshkin kolyshkin commented Feb 9, 2026

The test case named

podman build and remove basic alpine with TMPDIR as relative

always fails here because we're running it inside docker using overlayfs, and TMPDIR="." set by test results in overlay upperdir being on overlayfs. Since nested overlayfs is not supported, the mount fails:

overlay: filesystem on ..../upper not supported as upperdir

Since the test case is always failing and is not really testing any specific crun aspect, let's skip it.

This should bring Test (podman) back to green.

Fixes: #1999

The test case named

> podman build and remove basic alpine with TMPDIR as relative

always fails here because we're running it inside docker using
overlayfs, and TMPDIR="." set by test results in overlay upperdir
being on overlayfs. Since nested overlayfs is not supported, the
mount fails:

> overlay: filesystem on ..../upper not supported as upperdir

Since the test case is always failing and is not really testing
any specific crun aspect, let's skip it.

This should bring Test (podman) back to green.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @kolyshkin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a persistent CI failure by excluding a specific Podman build test case. The test, which involves building an Alpine image with a relative temporary directory, consistently fails when run inside a Docker container due to an incompatibility with nested OverlayFS. By skipping this non-critical test for crun aspects, the PR aims to restore stability to the Podman test suite.

Highlights

  • Test Exclusion: The test case named "podman build and remove basic alpine with TMPDIR as relative" has been added to the skip list in the run-tests.sh script.
  • Reason for Exclusion: This specific test consistently fails in the Docker-in-Docker environment due to issues with nested OverlayFS, where TMPDIR="." results in an overlay upperdir being on an overlayfs, which is not supported.
  • CI Stability: Skipping this test is expected to resolve the continuous failures in the Test (podman) suite, bringing it back to a green state.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request based on the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly excludes a persistently failing test case by adding it to the --skip list in the ginkgo command. The change is justified by the environment limitations explained in the description. I've added one minor suggestion to correct a potential typo in an issue number reference within a comment.

@packit-as-a-service
Copy link

TMT tests failed. @containers/packit-build please check.

@kolyshkin kolyshkin changed the title tests/podman: exclude ever failing test case ci: tests/podman: exclude ever failing test case Feb 9, 2026
@kolyshkin kolyshkin requested a review from giuseppe February 9, 2026 22:12
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 92ad4e2 into containers:main Feb 10, 2026
42 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test (podman) fails frequently in 'podman build and remove basic alpine with TMPDIR as relative'

2 participants