linux: drop unnecessary xasprintf() result check

[eriksjolund]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the error handling within the libcrun library by eliminating a superfluous check on the return value of xasprintf(). The xasprintf() function is typically implemented to manage its own allocation failures, meaning the explicit check for a negative return value was redundant. This change results in cleaner and more concise code without altering the functional behavior.

Highlights

• Code Cleanup: Removed an unnecessary error check for the xasprintf() function call in src/libcrun/linux.c.
• Error Handling: The xasprintf() function is designed to handle allocation failures internally, making an explicit return value check redundant and improving code clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/linux.c
  • Removed the if (UNLIKELY (ret < 0)) condition that checked the return value of xasprintf() when assigning to private_data->maskdir_proc_path.

Activity

• No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes an unnecessary check on the return value of xasprintf. Following the convention of other x prefixed functions in this codebase (like xmalloc), xasprintf is designed to terminate the program on memory allocation failure rather than returning an error code. This makes the check for a negative return value unreachable. The change simplifies the code and improves clarity by removing this redundant check. The modification is sound and I approve of it.

[kolyshkin]

Indeed, xasprintf never returns a negative value.

[kolyshkin]

Please rebase to pick some CI fixes so we can merge this.

[eriksjolund]

Please rebase to pick some CI fixes so we can merge this.

Done

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[giuseppe]

LGTM