linux: do not use errno after success

[eriksjolund]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines error handling logic within the libcrun library for Linux systems. It addresses a potential issue where the errno global variable could be inadvertently modified by subsequent function calls after an error occurred, leading to incorrect error reporting. The change ensures that the original error code is preserved for accurate debugging and logging.

Highlights

• Error Handling: Ensures that the correct errno value is captured immediately after a potential failure when writing to /proc/sys/, preventing it from being overwritten by subsequent successful operations before being used for error reporting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/linux.c
  • Preserved errno value before subsequent function calls to ensure accurate error reporting in libcrun_set_sysctl.

Activity

• The pull request was created by eriksjolund.
• A single commit was made to address a specific error handling issue.
• The change involves saving the errno value to a local variable immediately after a potential error to prevent its modification by subsequent operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where errno could be clobbered by a function call before being used to report an error. The change saves errno to a local variable immediately after a failed write call, ensuring the correct error code is preserved and reported. I've added a minor suggestion for consistency, but the fix is solid.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[eriksjolund]

I plan to do a small adjustment. (Probably tomorrow)

[kolyshkin]

LGTM. Please rebase to pick some CI fixes so we can merge this.

[eriksjolund]

LGTM. Please rebase to pick some CI fixes so we can merge this.

Done