linux: do not leak error

[eriksjolund]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines error handling within the libcrun library's Linux-specific device creation logic. By switching to an error wrapping mechanism, it ensures that underlying system call errors are properly propagated and enriched with context, rather than being potentially lost or replaced by a new error.

Highlights

• Error Handling Refinement: Replaced crun_make_error with crun_error_wrap when handling openat failures in libcrun_create_dev. This change ensures that existing error information is preserved and wrapped with additional context, preventing the original error from being overwritten or "leaked."

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/linux.c
  • Updated error handling for openat failures in libcrun_create_dev to use crun_error_wrap instead of crun_make_error for better error propagation.

Activity

• No specific activity (comments, reviews, etc.) was provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a memory leak in the error handling path of libcrun_create_dev. By replacing crun_make_error with crun_error_wrap, the code now properly wraps the existing error object from safe_openat instead of overwriting it. This not only prevents the memory leak but also preserves the original, more specific error context, leading to better diagnostics. The change is accurate and improves the robustness of the error handling.

[eriksjolund]

An alternative fix could be to use

return fd;

(I don't know what gives the best user experience for the end user)

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[kolyshkin]

LGTM

[kolyshkin]

Please rebase to pick some CI fixes so we can merge this.

[eriksjolund]

Please rebase to pick some CI fixes so we can merge this.

Done