Still a bit to do. will try and get it done through this week#30
Open
mattc0llier wants to merge 1 commit intoconstructorlabs:masterfrom
Open
Still a bit to do. will try and get it done through this week#30mattc0llier wants to merge 1 commit intoconstructorlabs:masterfrom
mattc0llier wants to merge 1 commit intoconstructorlabs:masterfrom
Conversation
| @@ -0,0 +1 @@ | |||
| {"id":"index.css","dependencies":[{"name":"_css_loader","parent":"/Users/matthewcollier/Documents/Sites/constructor-labs/project-cinema/src/index.css","resolved":"/usr/local/lib/node_modules/parcel-bundler/src/builtins/css-loader.js"}],"generated":{"css":":root {\n --bg-color: #000;\n --text-color: #fff;\n --highlight-color: grey;\n --link-color: blue;\n}\n\nbody,\nhtml {\n color: var(--text-color);\n background-color: var(--bg-color);\n\n /*Declare your font*/\n font-family: \"Source Serif Pro\", serif;\n\n -webkit-font-smoothing: antialiased;\n -moz-osx-font-smoothing: grayscale;\n}\n\n.app {\n}\nmain {\n display: flex;\n flex-direction: row;\n}\n","js":"\nvar reloadCSS = require('_css_loader');\nmodule.hot.dispose(reloadCSS);\nmodule.hot.accept(reloadCSS);"},"hash":"626be48813a0f1d51f52fb999b45f58f","cacheData":{"env":{}}} No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
These could be added to .gitignore
| const mainNode = document.querySelector("main"); | ||
|
|
||
| //Create the search previews Poster + Title + Year + Try to pull in rating | ||
| function createContentOverview(content, className = "content-overview") { |
Collaborator
There was a problem hiding this comment.
like the default args :)
|
|
||
| //Create the search previews Poster + Title + Year + Try to pull in rating | ||
| function createContentOverview(content, className = "content-overview") { | ||
| const overviewMarkUp = ` |
Collaborator
There was a problem hiding this comment.
Function is around 50 lines long and could be broken down into smaller chunks
| return buildURL(searchURL); | ||
| } | ||
|
|
||
| // function createContentParameters(imdbNumber) { |
Collaborator
There was a problem hiding this comment.
Commented out code can be removed
Collaborator
|
There is a lot of files in .cache and dist that can go into .gitignore to keep project. Would love to see a README next time. Also, more frequent commits will make your life easier in future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getting messy and 3 or so features 90% done