David Gridley Project Cinema#26
Open
DavidGridley wants to merge 6 commits intoconstructorlabs:masterfrom
Open
Conversation
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||
| <link rel="stylesheet" href="style.css"> | ||
| <link href="https://fonts.googleapis.com/css?family=Poppins:400,400i,500,500i,600,600i,700,700i,800,800i,900,900i" rel="stylesheet"> |
Collaborator
There was a problem hiding this comment.
importing every font weight feels like overkill
| @@ -0,0 +1,230 @@ | |||
| //e2c4cd31 API Key | |||
| const apiKey = "e2c4cd31"; | |||
| //Creates result template | ||
| function resultTemplate(arr) { | ||
| let results = arr.map(function(film){ | ||
| let poster = (film.Poster === "N/A") ? "images/noimage.png" : film.Poster; |
|
|
||
| //Populates results container | ||
| function populateResults(arr) { | ||
| resultsContainer.innerHTML = arr.join().replace(/,/g, " "); |
Collaborator
There was a problem hiding this comment.
This could be written as arr.join('') by joining with an empty string we avoid the commas being inserted
| //Listener for clicks on movie coontainers to either fetch information or trigger class toggles to hide previously displayed information from view (Only working in part, works the first time and then generates another lot of information, before then triggering toggle again) | ||
| function addInfoListener() { | ||
| const moreInfo = document.querySelectorAll(".more__info__button"); | ||
| moreInfo.forEach(button => { |
Collaborator
There was a problem hiding this comment.
do we need a forEach if we are doing delgation?
| grid-template-columns: 4fr 1fr; | ||
| } | ||
|
|
||
| form input { |
Collaborator
There was a problem hiding this comment.
selector woud better handled using BEM classes
Collaborator
|
Great work, but BEM usage needs more attention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.