test: add SELECT INTO statement parsing tests #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to verify that PL/pgSQL functions containing SELECT INTO statements are correctly parsed and hydrated. These tests serve as regression tests to ensure SELECT INTO parsing continues to work. Tests added: - should parse function with SELECT INTO statement - should parse function with SELECT INTO and schema-qualified table - should deparse function with SELECT INTO correctly - should parse function with DELETE statement (contrast test)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Update test comments to accurately describe that these are regression tests to ensure SELECT INTO parsing continues to work, rather than documenting a bug that no longer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests to verify that PL/pgSQL functions containing SELECT INTO statements are correctly parsed and hydrated. These tests ensure SELECT INTO parsing continues to work correctly.
Tests added:
Updates since last revision
Fixed test comments to accurately reflect that these are regression tests, not documentation of a bug. Removed misleading comments about parsing failures and placeholder issue URLs.
Review & Testing Checklist for Human
pnpm testinpackages/plpgsql-parserto confirm all 96 tests passNotes
During investigation, there was initial confusion where tests run from
/tmpwith incorrect module paths produced errors that were mistaken for a bug in@libpg-query/parser. When tests were run correctly from within the package directory, SELECT INTO parsing worked fine. The tests are valuable as regression tests to ensure this continues to work.Link to Devin run: https://app.devin.ai/sessions/f93a8b1ba9e54876a87e854e782a06ef
Requested by: Dan Lynch (@pyramation)