chore: add tests for SignatureVerifier#159
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional unit tests around SignatureVerifier behavior (including verifyWithKeyType) and adjusts Sonar configuration so the testapp module doesn’t drag down reported coverage.
Changes:
- Add new
SignatureVerifierTestcases covering unknown/negotiated algorithms and key-type/algorithm compatibility for RSA and Ed25519. - Add small test helpers to load test keys and produce SSH-format signatures.
- Exclude
testapp/**from Sonar coverage calculations.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sshlib/src/test/kotlin/org/connectbot/sshlib/crypto/SignatureVerifierTest.kt | Expands test coverage for signature verification across negotiated/self-described algorithms and key types. |
| build.gradle.kts | Excludes testapp from Sonar coverage to keep coverage metrics focused on covered modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also trim out testapp/* to keep code coverage up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also trim out testapp/* to keep code coverage up.