solve issue #309: obey a GapFill even if it replaces a message that was processed off the queue#957
Merged
gbirchmeier merged 2 commits intoconnamara:masterfrom Oct 16, 2025
Merged
Conversation
Member
gbirchmeier
commented
Apr 11, 2025
gbirchmeier
commented
- resolve Incorrect handling of SequenceReset Gap Fill Message #309
- close Sequence reset gap fill reverse verify logic #784 (because this supersedes it - attn @oclancy )
gbirchmeier
force-pushed
the
i309-fix
branch
2 times, most recently
from
667f11a to
bfa03cf
Compare
PR connamara#784 which is intended to fix issue connamara#309
gbirchmeier
force-pushed
the
i309-fix
branch
2 times, most recently
from
af71db7 to
8719299
Compare
... a message that was processed off the queue This is relevant only during a very specific and uncommon Gap Fill situation at the end of a ResendRequest series
trevor-bush
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.