Migrate Windows CI jobs from Windows 2019 to Windows 2025#3406
Draft
Corey Christous (cchristous) wants to merge 1 commit into
Draft
Migrate Windows CI jobs from Windows 2019 to Windows 2025#3406Corey Christous (cchristous) wants to merge 1 commit into
Corey Christous (cchristous) wants to merge 1 commit into
Conversation
Switch both Windows-pool references from s1-prod-windows (Windows 2019) to s1-windows-2025-amd64-4 (Windows 2025): - .semaphore/semaphore.yml: the 'Windows x64 Stable: Tests' block that runs on PR pushes. - .semaphore/playwright-e2e.yml: the parameterized Windows E2E pipeline (manual / scheduled task). Per the Builds team Windows 2025 rollout.
There was a problem hiding this comment.
Pull request overview
Migrates the two Windows Semaphore CI agent pool references from the aging s1-prod-windows (Windows Server 2019) to s1-windows-2025-amd64-4 (Windows Server 2025), aligning with the org-wide rollout to a supported baseline OS image.
Changes:
- Update Windows stable test block agent type in
.semaphore/semaphore.yml. - Update Windows Playwright E2E block agent type in
.semaphore/playwright-e2e.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.semaphore/semaphore.yml |
Switches PR-gated Windows x64 Stable Tests block to the Windows Server 2025 pool. |
.semaphore/playwright-e2e.yml |
Switches parameterized/scheduled Windows Playwright E2E block to the Windows Server 2025 pool. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Migrates the two Windows pool references in this repo from
s1-prod-windows(Windows Server 2019) tos1-windows-2025-amd64-4(Windows Server 2025):.semaphore/semaphore.yml— theWindows x64 Stable: Testsblock (runs on PR pushes; gated only by the release-markerskip:clause that does not apply to this change)..semaphore/playwright-e2e.yml— the parameterizedWindows x64: Playwright E2E Testsblock (manual / scheduled task pipeline).Why this is the right change:
s1-windows-2025-amd64-4pool is already provisioned and was first exercised in the semaphore-test canary.Why this is safe:
agent.machine.type; no commands, prologue, dependencies, or job structure are modified.npm,npx,choco,gh, andmake— all toolchain-portable and not pinned to a specific Windows SDK version.Testing
Windows x64 Stable: Testsblock insemaphore.ymlwill run on this PR (theskip:only fires onrelease.svg/.versions/next.txtchanges, neither of which are touched here). Look for that block to pass on the new agent.playwright-e2e.ymlis parameterized and not triggered on PR; it will be exercised the next time the manual/scheduled task runs after merge.