fix(service.yml): disable make plugin (forbidden on public repos)#211
Open
Charles Provencher (cprovencher) wants to merge 1 commit into
Open
fix(service.yml): disable make plugin (forbidden on public repos)#211Charles Provencher (cprovencher) wants to merge 1 commit into
Charles Provencher (cprovencher) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Charles Provencher (cprovencher)
May 29, 2026 20:13
View session
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
Disables the ServiceBot make plugin in service.yml because it is not allowed on public repositories, which was causing the cc-service-bot nightly run to fail.
Changes:
- Set
make.enabletofalseinservice.ymlso the nightly ServiceBot run skips the disallowed make plugin.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Charles Provencher (cprovencher)
added
the
review-hub:assigned
Charles Provencher (cprovencher)
assigned
Ian Feeney (ifeeneyconfluent) and unassigned
pmckenna555
Member
Author
|
🤖 Review Hub assignments
Scoring breakdown for Ian Feeney (@ifeeneyconfluent)
Generated by Review Hub. This comment is rewritten on each (re)assignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The cc-service-bot nightly run (job 7c09131f, 2026-05-28) failed for this repo:
cc-service-bot does not allow the
makeplugin on public repositories (it would manage/expose internal cc-mk-include). This repo is public, so the plugin can never run and the nightly errors out.Change
Set
make.enable: falseso service-bot skips the make plugin and processes the rest of the manifest cleanly.Safety
Draft PR for the owning team to review. If this repo genuinely needs service-bot-managed Makefile/mk-include, it must be private instead. Part of a sweep fixing the service-bot nightly; systemic validation regressions affecting ~262 other repos are fixed in confluentinc/cc-service-bot#2030.