Skip to content

feat: import confluent-common-bom for dependency version management #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Na Lou (nlou9) wants to merge 3 commits into
base: master
Choose a base branch
from
+21 −241
Draft

feat: import confluent-common-bom for dependency version management #977

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0cf2bd
feat: import confluent-common-bom for dependency version management
nlou9 Apr 29, 2026
fb24a18
fix: add confluent-common-bom snapshot repository
nlou9 Apr 29, 2026
eda1693
revert: remove internal CodeArtifact repo entry from public pom.xml
nlou9 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
262 changes: 21 additions & 241 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,117 +232,24 @@

<dependencyManagement>
<dependencies>
<!-- our deps-->
<!-- Confluent Common BOM - manages third-party dependency versions -->
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
<version>${avro.version}</version>
</dependency>
<!-- Pin the classgraph version to match version used in ce-kafka.
The outadated version is brought by schema-registry transitive
dependency mbknor-jackson -->
<dependency>
<groupId>io.github.classgraph</groupId>
<artifactId>classgraph</artifactId>
<version>${classgraph.version}</version>
</dependency>
<!-- Unify version of commons-io with ce-kafka, allow downstream repos to unpin -->
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>${commons-io.version}</version>
</dependency>
<!-- Unify version of commons-lang3 with ce-kafka, allow downstream repos to unpin -->
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>${commons-lang3.version}</version>
</dependency>
<!-- Pin version of commons-beanutils as it is used transitively not only by commons-validator -->
<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
<version>${commons-beanutils.version}</version>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<version>${commons-codec.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
<version>${commons-compress.version}</version>
</dependency>
<!-- Unify version of commons-validator with ce-kafka, allow downstream repos to unpin -->
<dependency>
<groupId>commons-validator</groupId>
<artifactId>commons-validator</artifactId>
<version>${commons-validator.version}</version>
</dependency>
<!-- Unify version of grpc-version with ce-kafka, allow downstream repos to unpin -->
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-bom</artifactId>
<version>1.75.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<!-- This is to match to okio version used in ce-flink / ce-kafka 7.8 -->
<dependency>
<groupId>com.squareup.okio</groupId>
<artifactId>okio-jvm</artifactId>
<version>${okio.version}</version>
</dependency>
<!-- This is to unify the version of Protocol Buffers across CP -->
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>${protobuf.version}</version>
</dependency>
<!-- snakeyaml is brought in by several confluent libraries
as "provided" dependency, thus leading to usage of
outdated versions. This instructs projects using this pom
to use this snakeyaml version, unless otherwise overriden.
After this change, we should remove all the snakeyaml re-definitions
in other Confluent repositories. -->
<dependency>
<groupId>org.yaml</groupId>
<artifactId>snakeyaml</artifactId>
<version>${snakeyaml.version}</version>
</dependency>
<!-- Unify jetty across CP, remove jetty definition from
rest-utils after this goes through -->
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-bom</artifactId>
<version>${jetty.version}</version>
<groupId>io.confluent</groupId>
<artifactId>confluent-common-bom</artifactId>
<version>0.0.1-SNAPSHOT</version>
<type>pom</type>
Comment on lines +237 to 240
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BOM version is hard-coded here (0.0.1-SNAPSHOT) while other BOMs in this file use properties. Consider introducing a dedicated property (e.g., confluent-common-bom.version) so updates are centralized and downstream builds can override it consistently if needed.

Copilot uses AI. Check for mistakes.
<scope>import</scope>
</dependency>
Comment on lines 236 to 242
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BOM is imported with a -SNAPSHOT version, but the only configured Maven repository does not explicitly enable snapshots. By default, snapshots are disabled for repositories, so this is likely to fail dependency resolution when building this parent POM. Prefer switching to a released BOM version, or explicitly enable snapshots for the confluent repository if using a snapshot is required.

Copilot uses AI. Check for mistakes.
<!-- snappy-java is brought in by kafka-clients and its version is specified
in ce-kafka -->
<dependency>
<groupId>org.xerial.snappy</groupId>
<artifactId>snappy-java</artifactId>
<version>${snappy.version}</version>
</dependency>
<!-- jose4j is used in ce-kafka and its version is specified
in ce-kafka, this is for maven projects to use the correct version -->
<dependency>
<groupId>org.bitbucket.b_c</groupId>
<artifactId>jose4j</artifactId>
<version>${jose4j.version}</version>
</dependency>
<!-- we define guava version above, its version is specified
in ce-kafka, this is for maven projects to use the correct version -->

<!-- Jackson BOM - not yet in confluent-common-bom -->
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>${guava.version}</version>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
<scope>import</scope>
<type>pom</type>
Comment on lines +246 to +250
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation for this jackson-bom dependency block is inconsistent with the surrounding <dependency> entries (the inner tags are less indented). Please align the indentation to match the rest of dependencyManagement for readability and to reduce noisy diffs in future edits.

Suggested change
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
<scope>import</scope>
<type>pom</type>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
<scope>import</scope>
<type>pom</type>

Copilot uses AI. Check for mistakes.
</dependency>
<!-- we define aws-java-sdk azure-identity and azure-storage-blob
versions, to match the versions in ce-kafka -->
<!-- AWS SDKs - not in confluent-common-bom -->
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-bom</artifactId>
Expand All @@ -357,6 +264,7 @@
<type>pom</type>
<scope>import</scope>
</dependency>
<!-- Azure - not in confluent-common-bom (BOM uses azure-sdk-bom instead) -->
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-identity</artifactId>
Expand All @@ -372,73 +280,16 @@
<artifactId>azure-security-keyvault-keys</artifactId>
<version>${azure-security-keyvault-keys.version}</version>
</dependency>
<!-- specify version of httpclient5 that is used in ce-kafka for compatibility in maven builds -->
<dependency>
<groupId>org.apache.httpcomponents.client5</groupId>
<artifactId>httpclient5</artifactId>
<version>${httpclient5.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
</dependency>
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<version>${jaxb.version}</version>
</dependency>
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-annotations</artifactId>
<version>${spotbugs.version}</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk18on</artifactId>
<version>${bouncycastle.jdk18.version}</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
<version>${bouncycastle.jdk18.version}</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bc-fips</artifactId>
<version>${bouncycastle.fips.version}</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bctls-fips</artifactId>
<version>${bouncycastle.tls-fips.version}</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-fips</artifactId>
<version>${bouncycastle.bcpkix-fips.version}</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcutil-fips</artifactId>
<version>${bouncycastle.bcutil-fips.version}</version>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<version>${gson.version}</version>
</dependency>

<!-- Jackson artifacts with individual versioning -->
<!-- log4j-slf4j-impl: keep for runtime scope (BOM does not set scope) -->
<dependency>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
<scope>import</scope>
<type>pom</type>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
<scope>runtime</scope>
<version>${log4j2.version}</version>
</dependency>
<!-- We fix the scala version to prevent downstream projects from bringing in
different minor versions of Scala via different dependencies -->

<!-- Scala - not in confluent-common-bom -->
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
Expand Down Expand Up @@ -497,42 +348,7 @@
<artifactId>connect-file</artifactId>
<version>${kafka.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
<version>${slf4j-reload4j.version}</version>
</dependency>
<!-- add version definition of logback that is
a transitive dependency of ce-kafka -> resource manager
This is needed as maven brings back dependency excluded in bazel -->
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>${logback-core.version}</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
<scope>runtime</scope>
<version>${log4j2.version}</version>
</dependency>
<dependency>
<groupId>ch.qos.reload4j</groupId>
<artifactId>reload4j</artifactId>
<version>${reload4j.version}</version>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>logredactor</artifactId>
<version>${logredactor.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>${netty.version}</version>
<scope>import</scope>
<type>pom</type>
</dependency>

<!--this is our own artifacts, but lets others inherit-->
<dependency>
<groupId>io.confluent</groupId>
Expand All @@ -551,49 +367,13 @@
</dependency>

<!--test deps-->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>${junit.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>${junit.jupiter.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.easymock</groupId>
<artifactId>easymock</artifactId>
<version>${easymock.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-module-junit4</artifactId>
<version>${powermock.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-core</artifactId>
<version>${powermock.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-api-easymock</artifactId>
<version>${powermock.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-api-mockito2</artifactId>
<version>${powermock.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-bom</artifactId>
Expand Down