Fix query parameters not being sent on API requests#22
Open
pchalacis wants to merge 1 commit into
Open
Conversation
Query params such as `reason` were collected in executeApiTool but never appended to the request URL, causing 400 errors on environments that require an audit reason. Extract URL building into helpers/query-params and add unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Hey @pchalacis, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executeApiToolcollected query parameters (e.g.reason) but never appended them to the request URLreasonRequired: truereturned400 {"Reason":["Reason required."]}for write tools likeupdate-setting-value-v2, even whenreasonwas providedsrc/helpers/query-params.tswith unit testsnpm testscript and run tests in CIRoot cause
queryParamswas populated fromexecutionParameterswithin: "query", but the map was never serialized ontourlPathbefore callinghttp.request().Test plan
npm test— 7 unit tests forbuildQueryStringandappendQueryParamsnpm run lint:checkupdate-setting-value-v2withreasonon Staging succeeds (HTTP 200)Made with Cursor