refactor pending_works_#120
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors how Runtime tracks pending work and determines when its event loop may exit, and adjusts Futex/Channel awaiter paths to match the new pending-work accounting.
Changes:
- Replace the “sentinel”
pending_works_behavior with an explicitexit_allowed_flag and updated loop exit condition. - Make
pending_works_non-atomic and restrictpend_work()/resume_work()to the current runtime thread (via assertions). - Move
pend_work()calls inFutex/Channelfrom request/enqueue time to the finish-handlestart()path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
include/condy/runtime.hpp |
Introduces exit_allowed_, refactors exit condition, and changes pending-work tracking to non-atomic + assertion-guarded APIs. |
include/condy/futex.hpp |
Moves pend_work() from request_wait_() enqueue to finish-handle start(). |
include/condy/channel.hpp |
Moves pend_work() from push/pop request enqueue paths to finish-handle start() for both push and pop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.