fix(sync): remove non-existent ComponentManager dependency#97
fix(sync): remove non-existent ComponentManager dependency#97jordanpartridge wants to merge 1 commit into
Conversation
The SyncComponentsCommand was importing and injecting ComponentManager which does not exist in the codebase, causing a fatal error. Removed the unused import and parameter since the command only needs JsonComponentRegistrar and ServiceProviderDetector. Fixes #95 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes No complex logic involved—straightforward removal of an unused dependency injection that resolves a fatal error. Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes issue #95 by removing the non-existent ComponentManager class dependency from SyncComponentsCommand.php. The sync-components command was failing with a fatal error because it attempted to inject a class that doesn't exist in the codebase.
Changes
use App\Services\ComponentManager;import statementComponentManager $componentManagerparameter from thehandle()methodJsonComponentRegistrarandServiceProviderDetectorwhich are the actual required dependenciesWhy This Fix
The SyncComponentsCommand was attempting to inject ComponentManager on line 19, but this class does not exist in the codebase. This caused the command to fail at runtime with a service container resolution error.
Related Issues
Closes #95
Testing
php artisan sync-componentsto verify the command executes without errorsSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.