Add typing_extensions runtime dependency to meta.yaml#54
Closed
Michael-J-Ward wants to merge 1 commit intoconda-forge:mainfrom
Closed
Add typing_extensions runtime dependency to meta.yaml#54Michael-J-Ward wants to merge 1 commit intoconda-forge:mainfrom
typing_extensions runtime dependency to meta.yaml#54Michael-J-Ward wants to merge 1 commit intoconda-forge:mainfrom
Conversation
This is required as of `datafusion-python` v40. ref: apache/datafusion-python#750
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
andygrove
approved these changes
Sep 19, 2024
Contributor
andygrove
left a comment
There was a problem hiding this comment.
Thanks @Michael-J-Ward
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Change
datafusion-pythonrequires the runtime dependencytyping_extensionsas of v40.We updated our own conda recipe that we use to build conda nightlies, but I failed to upstream that change here.
I believe the v40.1.0 PR needs to be updated with the change in this PR, then those tests should pass and v41 can be rebased off that change.
ref: apache/datafusion-python#750
Note
If you have any suggestions on keeping these two in line, please let me know. Editing the build file in two places seems non-optimal.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Please add any other relevant info below: