RFC: Canvas and SVG Renderer Implementation Plan#2299
Closed
Conversation
This plan outlines the approach for adding: - CanvasPointRenderer: Canvas 2D fallback when WebGL contexts exhausted - SVG export utility: Clean SVG generation for image export The plan is intended for team review and discussion before implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
===========================================
- Coverage 86.54% 69.39% -17.16%
===========================================
Files 733 733
Lines 39292 39292
Branches 9697 9688 -9
===========================================
- Hits 34006 27266 -6740
- Misses 4971 11288 +6317
- Partials 315 738 +423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
CODAP-295-canvas-svg-renderer-plan
|
| Run status |
|
| Run duration | 03m 13s |
| Commit |
|
| Committer | Kirk Swenson |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
4
|
| View all changes introduced in this branch ↗︎ | |
Member
Author
|
The features described here have already been implemented. No need for this PR any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an implementation plan for two new renderers to address WebGL context limitations and SVG export needs:
Purpose
This is a Request for Comments - the PR contains only the plan document (
v3/doc/point-rendering-plan.md) for team review before implementation begins.Key Design Decisions
Open Questions
Review Request
Please review the plan and leave comments on:
🤖 Generated with Claude Code