Conversation
dornbirndevelops
left a comment
dornbirndevelops
left a comment
There was a problem hiding this comment.
nice to see some examples for 2.X
really looking forward to this version 👍
| @@ -0,0 +1,4 @@ | |||
| from conan import ConanFile | |||
There was a problem hiding this comment.
I could not see the usage of this file in the sample execution. Is this intentional?
| @@ -0,0 +1,4 @@ | |||
| from conan import ConanFile | |||
There was a problem hiding this comment.
I could not see the usage of this file in the sample execution. Is this intentional?
| run("conan create ai") | ||
| out = run("conan install game", error=True) | ||
| # NOTE This output shows the downstream conflict not the immediate | ||
| assert "ERROR: Version conflict: ai/1.0->math/2.0, game/1.0->math/1.0" in out |
There was a problem hiding this comment.
that is weird. I would have expected now something like below:
| assert "ERROR: Version conflict: ai/1.0->math/2.0, game/1.0->math/1.0" in out | |
| assert "ERROR: Version conflict: ai/1.0->math/2.0, engine/1.0->math/1.0" in out |
what am I missing?
There was a problem hiding this comment.
Nop, this is the current implementation. The conflict shown is because the engine->math conflict is propagated down to game. If it wasn't propagated it wouldn't conflict, so the conflict needs to be tracked down from game.
At least this is the current implementation, we can try to improve the information there, but that would require changes in code.
This will be run by CI, so we will make sure that the examples work and they align with the release.
| name = "ai" | ||
| version = "1.0" | ||
|
|
||
| requires = "math/2.0" No newline at end of file |
dornbirndevelops
left a comment
dornbirndevelops
left a comment
There was a problem hiding this comment.
nice to see some examples for 2.X
really looking forward to this version 👍
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
Thanks for the review!
| @@ -0,0 +1,4 @@ | |||
| from conan import ConanFile | |||
| @@ -0,0 +1,4 @@ | |||
| from conan import ConanFile | |||
| run("conan create ai") | ||
| out = run("conan install game", error=True) | ||
| # NOTE This output shows the downstream conflict not the immediate | ||
| assert "ERROR: Version conflict: ai/1.0->math/2.0, game/1.0->math/1.0" in out |
There was a problem hiding this comment.
Nop, this is the current implementation. The conflict shown is because the engine->math conflict is propagated down to game. If it wasn't propagated it wouldn't conflict, so the conflict needs to be tracked down from game.
At least this is the current implementation, we can try to improve the information there, but that would require changes in code.
This will be run by CI, so we will make sure that the examples work and they align with the release.
…orial_consuming_versioning_conflicts
3 participants
This only works after conan-io/conan#10624 is merged.
Goals: