Fix linux build #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is in Foundation, not in stdlib, so needs to be explicitly imported to be able to build on Linux.
they're apple specific extensions. Use glibc instead.
Contributor
|
@nevyn Thank you for the PR. Could you please make sure the CI checks pass, maybe add linux check alongside the Mac one? |
Author
|
@eugenebokhan The code builds and tests successfully locally on my Mac. The build errors look like CI issue, perhaps bumping the Swift version will help? There is no |
nevyn
force-pushed
the
fix/linux-build
branch
from
a239163 to
70cf651
Compare
I was able to build this before because Swift 6.1 would just pick up kvSIMD from higher up in the dependency chain, which was wrong. In Swift 6.2, we need to explicitly depend on kvSIMD to have a chance to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code was using Apple specifics. Removing them makes this library work fine on Linux.