Minor fix to fetching layers attrbute from running viewer#1165
Merged
Conversation
constantinpape
approved these changes
Feb 13, 2026
Contributor
constantinpape
left a comment
constantinpape
left a comment
There was a problem hiding this comment.
Looks good. The test failure seems to be stochastic and unrelated.
Collaborator
Author
|
Yeah it's the weird |
Collaborator
Author
|
Nice. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay this was actually super minor (aims to fix #1141)
TLDR: I just needed to switch the logic a bit for doing the expected thing: looking for the layers existing in the running
_viewerstate.What do you think @constantinpape? (just tested the behaviour @Sagnik700 reported, and seems like it's fixed)