Draft
Conversation
* Unify 2D and 3D annotators into single implementation This commit consolidates the 2D and 3D annotator implementations into a unified Annotator class that handles both dimensions automatically. Key changes: - Add new annotator.py with unified Annotator class and annotator() function - Implement _detect_ndim() helper for automatic dimensionality detection - Simplify annotator_2d.py and annotator_3d.py to thin wrapper classes - Add comprehensive test suite in test_annotator.py - Maintain full backward compatibility with existing APIs - Export new unified API alongside existing functions in __init__.py The unified implementation: - Auto-detects 2D vs 3D from image shape when ndim=None - Conditionally creates dimension-specific widgets - Validates ndim parameter matches image dimensions - Loads AMG state only for 3D volumes (as per original behavior) - Preserves all existing function signatures and CLI entrypoints All existing code using annotator_2d(), annotator_3d(), Annotator2d, or Annotator3d continues to work unchanged. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Cosmetics * Fix sam predictor selection logic * Remove annotator_2d and 3d, update image_series_annotator * Update CLI tests * Disable GUI tests on windows * Unify per slice and volumetric segmentation widget * Update tests --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
* Add script for statistical analysis WIP * Fix dataset pool names * Update scripts for statistical analysis * Add doc and more cosmetic changes --------- Co-authored-by: Anwai Archit <anwai.archit@gmail.com>
* Fix issue in batched inference * Feaure: Added Apple silicon support in nb finetuning. (#1161) Checks if Cuda or MPS (Apple Silicon) is available. Otherwise defaults to GPU. * Simply device allocation in finetuning notebook (#1163) * Simply device allocation in finetuning notebook * Update finetuning python scripts --------- Co-authored-by: Constantin Pape <constantin.pape@informatik.uni-goettingen.de> Co-authored-by: Hendrik Windel <15370203+HendrikLamar@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the base branch for the UI redesign https://github.com/computational-cell-analytics/SAM2_Experiments/issues/48