Conversation
Member
Author
|
Benchmarks: |
adithyaov
commented
Sep 30, 2022
src/Streamly/Internal/LZ4.hs
Outdated
| ++ " maxCompLenC: " ++ show maxCompLenC | ||
| ++ " uncompLenC: " ++ show uncompLenC | ||
| (MArray.Array cont dstBegin_ dstBegin dstMax) <- | ||
| newarr@(MArray.Array cont arrStart arrEnd arrBound) <- |
Member
Author
There was a problem hiding this comment.
Make a new pinned array!
Member
|
Need to update stack.yaml for appveyor build. |
|
Hi, is this PR still running? I'd like to use lz4 in latest streamly and happy to help :) |
Member
|
@TheKK the last update on this was long ago, so it is stalled. @adithyaov can you update this, I will review. See if @TheKK can help in some way if you are busy. |
Member
Author
|
Hey @TheKK this PR is stalled. If possible please send a new PR or update this PR accordingly. I can review it.
|
|
Got it. I'd like to work on this one but still have other task to work on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.