Conversation
README.md
Outdated
|
|
||
| > **NOTE:** Only Swift 5.4.2+ is supported | ||
| > | ||
| > **NOTE:** This action requires a prior |
There was a problem hiding this comment.
Is this entirely accurate? Is this needed if you are using lld? If you are using SPM, then the default is lld, and this wouldn't be needed right?
There was a problem hiding this comment.
I don't know what SPM does, or does by default. You may be correct about that. It would be better of course if this were made unnecessary and since the action uses setup-vsdevenv anyway simply did it in the right order, but I was unable to figure out how to make that work. How would you suggest updating this note?
There was a problem hiding this comment.
I think that expanding it to be explicit about when it requires that or loosening the assertion that the action "requires" setup-vsdevenv to something along the lines of "may be needed if your build requires finding tools from the MSVC toolset" would be sufficient.
2 participants
No description provided.