adding nodejs-v2 and python3-v2

[SamWSoftware]

Adding two basic repos. I've tested these and they will both compile and run sls offline to show the swagger.

Later it would be cool to generate the swagger then to do some tests on it to make sure that everything is where it's supposed to be. Kind of like smoke tests.

[SamWSoftware]

I need to work out why things are breaking in Node 12 and 14

[bfaulk96]

It's a little sneaky, but looks like the generation itself is failing in GH Actions..

generating swagger files in all test repos...error

[bfaulk96]

We will probably want an additional parameter to cover the optional required param:

Suggested change

	},
	},
	notRequired: {
	type: 'string',
	description: 'this param should be optional'
	},

[bfaulk96]

Same here, should cover the other branches of implicit and explicit required === false

Suggested change

	},
	},
	explicitOptional: {
	required: false,
	description: 'this header is optional',
	},
	implicitOptional: {
	description: 'this header is implicitly optional',
	},

[bfaulk96]

Shouldn't these also point to the root folder? Would be better to have serverless-offline installed at the root as a devDep once than for each of Node and Python serverless to install the same version separately

[bfaulk96]

Same q here

[bfaulk96]

We should probably make a TODO or file an Issue to add actual parameter validation here instead of simply checking the lengths, right?

[bfaulk96]

Could you explain this one to me? There's probably a simpler way to do this, i.e. slicing the file at the index where we find whatever the python comment is

[bfaulk96]

That way it would always be dynamic

[bfaulk96]

😄

Suggested change

	// Only required when running the smoke tests. so ignote when running unit tests
	// Only required when running the smoke tests. so ignore when running unit tests

[bfaulk96]

Don't we want this to reject on error?

Suggested change

	console.log('error');
	resolve(1);
	console.error('Error generating swagger', err);
	reject(err);

[bfaulk96]

Same question here

Suggested change

	console.log('stderr');
	resolve(1);
	return;
	console.log('Error generating swagger', stderr);
	reject(stderr);
	return;