Skip to content

added documentation#2

Closed
FND wants to merge 1 commit into
masterfrom
docs
Closed

added documentation#2
FND wants to merge 1 commit into
masterfrom
docs

Conversation

@FND

@FND FND commented Nov 23, 2017

Copy link
Copy Markdown
Contributor

based on @mechanoid's efforts: #1

I'm not happy with the way bundles are taken for granted, but hopefully we'll be able to link to the website in the future (as this is not adaptor-specific).

Perhaps we should also explain why we bypass the view engine?

based on @mechanoid's efforts:
#1
Comment thread README.md
```

These JSX modules are then combined into a single `views.js` bundle, e.g. using
[faucet](faucet.org) - see

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that URL is not correct - need to discuss with @moonglum

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faucet-pipeline.org is the correct URL

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in 0d4389a.

Comment thread README.md
$ npm install complate-express
```

After registering complate's middleware, use `Response#complate` for rendering:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better:

Register complate's middleware and use Response#complate for rendering:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, adopted (with a slight tweak) in 0d4389a.

@youngbrioche youngbrioche left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FND

FND commented Nov 23, 2017

Copy link
Copy Markdown
Contributor Author

Merged as 0d4389a.

@FND FND closed this Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants