Conversation
leouieda
left a comment
There was a problem hiding this comment.
Great work! Left some corrections and comments. You can merge them directly on GitHub if you want.
There was a problem hiding this comment.
Image is waaaaaay too large. Crop it to 16:9 ratio and downscale it to 1280x720 pixels. Save it as a JPG and use compression to reduce the size. Otherwise, anyone opening the page has to download 10Mb of images.
There was a problem hiding this comment.
Image is too large. Crop it to 16:9 ratio and downscale it to 1280x720 pixels. Use compression on the jpg if haven't already.
|
Thanks Leo. I like the corrections and think that we could maybe use this post as a template. I also still have a doubt about when do we use "I", since me and @arthursmacedo are co-authoring this post. The reader would not really know who wrote each section of the text, so it would not know who exactly the text is referring to. |
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Your names are in the headings of each section. |
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
…accessibility Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
Co-authored-by: Leonardo Uieda <leo@uieda.com>
No description provided.