Merged
Conversation
jckenny59
approved these changes
Mar 14, 2026
Collaborator
jckenny59
left a comment
jckenny59
left a comment
There was a problem hiding this comment.
LGTM 👍 I broke a lot of the method annotations on the next branch with a merge conflict. But updated again 💯
jckenny59
reviewed
Mar 14, 2026
Comment on lines
1
to
+12
| attrs >=17.4 | ||
| black >=22.12.0 | ||
| bump-my-version | ||
| compas_invocations2 | ||
| compas_invocations2[mkdocs] @ git+https://github.com/compas-dev/compas_invocations2.git@mkdocs | ||
| invoke >=0.14 | ||
| pytest | ||
| pythonnet | ||
| rhino-stubs | ||
| ruff | ||
| sphinx_compas2_theme | ||
| tomlkit | ||
| twine | ||
| wheel | ||
| wheel No newline at end of file |
Collaborator
There was a problem hiding this comment.
@gonzalocasas I am not sure why the docs side is failing, this is kind of out of my wheel house.... but this was the suggested update from gemini.
# requirements-dev.txt
# add this line at the very top:
-r requirements.txt
Collaborator
There was a problem hiding this comment.
I don't know if this makes much sense... also not sure if it was because I updated the uv.lock on my side ¯_(ツ)_/¯
jckenny59
reviewed
Mar 14, 2026
Comment on lines
+11
to
+12
| from compas_invocations2 import grasshopper | ||
| from compas_invocations2 import mkdocs |
Collaborator
There was a problem hiding this comment.
The other gemini suggestion was to change:
# tasks.py
# remove this line:
from compas_invocations2 import mkdocs
# change this line:
mkdocs.docs,
# to:
docs.docs,
Again not my area of expertise really, but let me know if these make any sense, or what next to do :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compas_fabas dependencyuvas suggested package manager to installThis is how the new docs look like:
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.