-
Notifications
You must be signed in to change notification settings - Fork 17
Added Gunslinger Class #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't sleep last night, so checked this file in half-asleep state, take comments with grain of salt (and there's also some stuff i probably missed... like the fact there's no links to the article within elements)
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things from previous review weren't addressed. Also, after everything is solved, whole file still needs to have "url setters"
|
Still don't know how exactly to deal with Edit: Found a way to fix it. |
Added Gunslinger Class
https://www.dandwiki.com/wiki/Gunslinger_(5e_Class)