Skip to content

Conversation

@Azzzzzy
Copy link
Contributor

@Azzzzzy Azzzzzy commented Oct 20, 2019

@Azzzzzy Azzzzzy requested a review from a team October 20, 2019 22:58
Copy link
Collaborator

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't sleep last night, so checked this file in half-asleep state, take comments with grain of salt (and there's also some stuff i probably missed... like the fact there's no links to the article within elements)

Copy link
Collaborator

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things from previous review weren't addressed. Also, after everything is solved, whole file still needs to have "url setters"

@Azzzzzy
Copy link
Contributor Author

Azzzzzy commented Nov 23, 2019

Still don't know how exactly to deal with

      <description>You can mark one enemy and gain advantage against it until you target another creature, the target drops to 0 HP or 1 minute passes.</description>
    </sheet>
    <rules>
      <stat name="sniper mark:uses" value="1" bonus="base" />
      <stat name="sniper mark:uses" value="wisdom:modifier" bonus="base" />
      <stat name="sniper mark:rest" value="Long Rest" />
      <stat name="sniper mark:rest" value="Rest" level="20" />
    </rules>

Edit: Found a way to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants