Skip to content

Feat/pdjb 634 gas upload page#1120

Merged
AEPR merged 24 commits intomainfrom
feat/PDJB-634-gas-upload-page
Mar 27, 2026
Merged

Feat/pdjb 634 gas upload page#1120
AEPR merged 24 commits intomainfrom
feat/PDJB-634-gas-upload-page

Conversation

@AEPR
Copy link
Copy Markdown
Contributor

@AEPR AEPR commented Mar 20, 2026

Ticket number

PDJB-634

Goal of change

Add the file upload page to the registration journey.

Description of main change(s)

Implements the gas upload page as part of the property registration journey.

Extra changes/improvements:

  • Deletes virus scan callbacks when they are processed
  • Switch to using a sealed class for virus callbacks

Anything you'd like to highlight to the reviewer?

Include e.g. anything unusual about the PR, where there was some debate over how to implement it, or anywhere you were
unsure of the approach to take and would like specific feedback.

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Unit tests for new logic (e.g. new service methods) have been added
  • Single page integration tests have been added for any unhappy-flow UI features, e.g. validation errors
  • New journey steps have been added to the appropriate journey integration test(s)
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here
  • Seed data has been updated as needed for your feature to be tested without having to e.g. register a new property
  • NftDataSeeder has been updated to reflect any changes to the database schema
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket)

@AEPR AEPR force-pushed the feat/PDJB-634-gas-upload-page branch from a16c3a6 to 07809a8 Compare March 25, 2026 14:41
@AEPR AEPR marked this pull request as ready for review March 26, 2026 13:54
Copy link
Copy Markdown
Collaborator

@Travis-Softwire Travis-Softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor points, but LGTM

Comment thread .run/local.run.xml
Comment thread .run/local-no-server.run.xml
Comment thread src/main/resources/templates/forms/registrationCertificateForm.html Outdated
@AEPR AEPR enabled auto-merge March 27, 2026 09:28
@AEPR AEPR added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit 31cee13 Mar 27, 2026
8 checks passed
@AEPR AEPR deleted the feat/PDJB-634-gas-upload-page branch March 27, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants