This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Conversation
|
Where does the styling come from? |
kurt-uk
reviewed
Nov 24, 2023
| "type": "NumberField", | ||
| "title": "What is the estimated cost of backfilling roles?", | ||
| "hint": "<label for=\"KEnthg\" class=\"govuk-hint\" style=\"display: none;\">Amount in pounds</label>" | ||
| "hint": "<label for=\"KEnthg\" style=\"position: absolute; width: 1px; height: 1px; margin: -1px; padding: 0; overflow: hidden; clip: rect(0, 0, 0, 0); border: 0;\">What is the estimated cost of backfilling roles?</label>" |
There was a problem hiding this comment.
Can you double check if the text of this needed changing or if you needed to include an aria
There was a problem hiding this comment.
Jira ticket has accessibility report with soltions in it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FS-3729 Form runner - Critical accessibility issue in Roles and recruitment form DPIF (Form elements must have labels)
Added label but also hidden it using CSS as prototype does not display a hint
Type of change
How Has This Been Tested?
Checklist: