Conversation
Previously, pushing to a branch with an open PR triggered both the push and pull_request workflows. Limit push to master only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up QEMU |
There was a problem hiding this comment.
QEMU is OK I guess for this case, but the build will be slower than running two parallel jobs on native architectures and merging them as I mention in the issue.
There was a problem hiding this comment.
Is build speed an issue? I prefer this because keeps the CI yaml simple but I am happy to change as well.
There was a problem hiding this comment.
What does @sebastian-nagel prefer? See for reference: https://github.com/grobidOrg/grobid/blob/b36cdd4fbf33661678dcbf213fe5ec38baa8478e/.github/workflows/ci-build-unstable.yml
There was a problem hiding this comment.
I think it depends. 😅
If we keep running the image on our own computer and we might need to change the code if something happens, I'd prefer a faster buidl.
However, I can imagine having this docker image running on rf and provide an interface where we could pull the data and generate the statistics remotely, without having to use our laptop (took at least 30 minutes on my m2).
This would need some more work, but if so we won't care about build time IMHO.
lfoppiano
left a comment
There was a problem hiding this comment.
Could you please trigger a build so that I can test also the resulting image? I will try to process the stats for this month to compare the speed with an non-arm version 🙏
It's already built: https://github.com/commoncrawl/cc-crawl-statistics/pkgs/container/cc-crawl-statistics%2Fstats/703032387?tag=pr-28 |
This PR enables building container images for
linux/amd64andlinux/arm64platforms. Fixes #27Verified on MacOS: