python-sdk: fix ruff lint issues in client and verify modules#36
Closed
python-sdk: fix ruff lint issues in client and verify modules#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
client.py,verify.py, and tests, which need to be fixed without changing verifier semantics.Description
"actor"key inbuild_commons_requestwhile preserving the intended actor override behavior via**bodythen trailing"actor"assignment incommandlayer/client.py.commandlayer/client.py,commandlayer/verify.py, andtests/test_client.pywithout altering logic.commandlayer/verify.pyandcommandlayer/__init__.pyand added minimalcastusage to keep type-check correctness without changing runtime behavior.client.pyandverify.pyto address mypy shape expectations while keeping verification logic intact.Testing
cd python-sdk && python -m ruff check ., which passed with no issues.cd python-sdk && python -m mypy commandlayer, which completed successfully (no issues reported).cd python-sdk && python -m pytest, which produced test failures unrelated to the lint-only scope (7 tests failing; see test output), so pytest did not fully pass.cd typescript-sdk && npm run typecheck && npm run build && npm run test:unitandnode scripts/parity-check.mjs), which failed due to existing TypeScript compile/build errors and missing build artifact, and were intentionally left unchanged by this lint-only fix.Codex Task