Skip to content

python-sdk: fix ruff lint issues in client and verify modules#36

Closed
GsCommand wants to merge 1 commit intomainfrom
codex/fix-python-sdk-lint-issues
Closed

python-sdk: fix ruff lint issues in client and verify modules#36
GsCommand wants to merge 1 commit intomainfrom
codex/fix-python-sdk-lint-issues

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

  • The Python SDK ruff lint run reported import ordering, duplicate key, and E501 long-line violations in client.py, verify.py, and tests, which need to be fixed without changing verifier semantics.

Description

  • Removed the duplicate literal "actor" key in build_commons_request while preserving the intended actor override behavior via **body then trailing "actor" assignment in commandlayer/client.py.
  • Reformatted multi-argument signatures, wrapped long expressions, and split long lines to satisfy the 100-char E501 limit across commandlayer/client.py, commandlayer/verify.py, and tests/test_client.py without altering logic.
  • Reorganized import order and grouped imports to satisfy Ruff in commandlayer/verify.py and commandlayer/__init__.py and added minimal cast usage to keep type-check correctness without changing runtime behavior.
  • Made small typing/casting adjustments in client.py and verify.py to address mypy shape expectations while keeping verification logic intact.

Testing

  • Ran cd python-sdk && python -m ruff check ., which passed with no issues.
  • Ran cd python-sdk && python -m mypy commandlayer, which completed successfully (no issues reported).
  • Ran cd python-sdk && python -m pytest, which produced test failures unrelated to the lint-only scope (7 tests failing; see test output), so pytest did not fully pass.
  • Ran TypeScript checks and parity tools (cd typescript-sdk && npm run typecheck && npm run build && npm run test:unit and node scripts/parity-check.mjs), which failed due to existing TypeScript compile/build errors and missing build artifact, and were intentionally left unchanged by this lint-only fix.

Codex Task

@GsCommand GsCommand closed this Apr 24, 2026
@GsCommand GsCommand deleted the codex/fix-python-sdk-lint-issues branch April 24, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant