Fix TypeScript template test discovery for Node 20#34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
globSyncand passing wildcard patterns tonode --testis unreliable, so test discovery should explicitly locate test files and skip missing optional suites.Description
typescript-sdk/scripts/template-tests.mjsusingexistsSync,readdirSync,path, andfileURLToPathto collect*.test.mjsfiles and invokenode --testwith explicit file paths.cwdset to the repository root.Testing
cd typescript-sdk && npm run typecheck && npm run build && npm run test:unit, which failed at existingsrc/index.tsTypeScript errors so the build/tests did not complete.node scripts/parity-check.mjs, which failed because TypeScript build artifacts are absent when the build fails.Codex Task