Preserve optional template-suite handling and fix TypeScript verifier regressions#33
Closed
Preserve optional template-suite handling and fix TypeScript verifier regressions#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
runtime/tests/*.test.mjs) are skipped instead of invokingnode --teston unmatched globs which causednpm run test:templateto fail.tsc/build and caused unit-test failures.receipt_idsemantics unchanged and avoid broad verifier policy changes in TypeScript.Description
typescript-sdk/scripts/template-tests.mjsto resolve globs withglobSyncand skip optional suites, invokingnode --testonly with matched files.typescript-sdk/src/index.tsby addingReceiptProtocolMetadata, correctingCommandResponse/LegacyBlendedReceiptusages, fixingextractReceiptVerbto use canonical verb extraction, and correcting the signer/receipt-id value wiring used inverifyReceiptresults.typescript-sdk/scripts/unit-tests.mjsto include a canonicalverbin the end-to-end receipt so tests that read the canonical verb pass.scripts/parity-check.mjsnormalization to compare shared semantic verification signals (alg/canonical/hash/signature) between TS and Python reports so parity focuses on shared verification semantics while tolerating known top-levelokdifferences tied to receipt-id policy.Testing
cd typescript-sdk && npm run typecheck && npm run build && npm run test:unitand the full unit+template suite succeeded (44 passed, 0 failedafter fixes).node scripts/parity-check.mjsand parity check passed (TypeScript and Python agree on shared verification semantics).npm run test:templateno longer fails whenruntime/tests/*.test.mjsis absent because the suite is now skipped as optional.Codex Task