Align Python receipt verifier with TypeScript parity for receipt_id semantics#32
Closed
Align Python receipt verifier with TypeScript parity for receipt_id semantics#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ts_ok=truebutpy_ok=falsebecause the Python verifier treatedreceipt_id_matches=falseas fatal, diverging from TypeScript semantics.receipt_id_matches=falseis reported but does not makeok=false, while still enforcing required signature/hash/alg/canonical checks.Description
python-sdk/commandlayer/verify.pyremovedreceipt_id_matchesfrom theokcalculation and addedreceipt_id_presentto the reportedchecksin both normal and exception paths.python-sdk/commandlayer/types.pyaddedreceipt_id_present: booltoVerifyChecksso the typed result includes the new field.ReceiptProtocolMetadatatype, correctedCommandResponse/LegacyBlendedReceiptgenerics and field wiring (signer_id/signerId), updatedextractReceiptVerbto usegetReceiptVerb, and updated the unit-test fixture to include a canonicalverbto satisfy an existing assertion; changes are intypescript-sdk/src/index.tsandtypescript-sdk/scripts/unit-tests.mjs.Testing
cd typescript-sdk && npm run typecheck && npm run build && npm run test:unit, which completed successfully (44 passed, 0 failed).node scripts/parity-check.mjs, which reports TypeScript/Python agreement and all parity fixtures passing.Codex Task