Fix template test discovery without node:fs globSync#30
Closed
Fix template test discovery without node:fs globSync#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
globSyncfromnode:fs, which isn't exported and caused a SyntaxError during CI test discovery.src/index.ts.Description
rootbase URL for resolution intypescript-sdk/scripts/template-tests.mjs.findTestFileshelper that usesexistsSyncandreaddirSyncto check for directory existence and collect files ending with*.test.mjs.node --testwith explicit file paths for each discovered suite.Testing
npm run typecheckintypescript-sdk, which failed due to pre-existingsrc/index.tstype errors unrelated to this change. (failed)npm run buildintypescript-sdk, which failed at the DTS generation stage for the same pre-existing type errors. (failed)npm run test:unitintypescript-sdk, which failed because the build step failed first. (failed)node scripts/template-tests.mjsdirectly, which exercised the new discovery logic and ran template tests (7 passed, 2 existing runtime tests failed), demonstrating discovery now works without usingglobSync. (partial pass)Codex Task