Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
{ receipt, runtime_metadata? }withreceiptas the signed artifact andruntime_metadataoptional and unsigned.Description
receiptsigned,runtime_metadataunsigned) and clarified thatreceipt.x402is protocol metadata (not a first-class commercial surface); updatedREADME.md,QUICKSTART.md,EXAMPLES.md,DEVELOPER_EXPERIENCE.md,DEPLOYMENT_GUIDE.md,RELEASE_GUIDE.md,MAINTAINER_GUIDE.md,typescript-sdk/README.md, andpython-sdk/README.md.x402://...entry construction from both SDKs so client payloads includereceipt.x402verb/version metadata only (files changed:typescript-sdk/src/index.ts,python-sdk/commandlayer/client.py).test_vectors/(files changed:receipt_valid.json,receipt_valid_v1.json,receipt_invalid_sig.json,receipt_wrong_kid.json,receipt_malformed_pubkey.json,public_key_base64.txt,expected_hash.txt, andtest_vectors/README.md).npm testpackage-local by removing the automatic cross-repo runtime tests and adding an explicit optional integration scriptnpm run test:integration; updatedtypescript-sdk/package.json,typescript-sdk/scripts/unit-tests.mjs, andtypescript-sdk/README.mdto document the reproducible workflow.trace->runtime_metadata), but made it explicit in docs that this is compatibility-only and not the canonical public contract (normalization code left intact:typescript-sdk/src/index.tsnormalization andpython-sdk/commandlayer/client.pynormalization behavior unchanged).Testing
python -m pytestinpython-sdkand observed all tests pass (23 passed, 1 warning).rgsearches to ensurex402://literal is no longer present in public/examples and that docs now consistently state the canonical{ receipt, runtime_metadata? }model; these checks returned no remainingx402://occurrences.git diff --checkto ensure no whitespace/patch issues and confirmed diffs are clean.npm testflow but the build toolchain (tsup) was not available in this execution environment so fullnpm testcould not be completed here; to address reproducibility the package now documentsnpm testas package-local and providesnpm run test:integrationfor the optional cross-repo runtime checks.If desired next steps: run
cd typescript-sdk && npm ci && npm testin a provisioned Node/npm environment to validate the TypeScript package-local tests before tagging the release.Codex Task