Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ruff/mypy/pytestvalidation.Description
@types/nodeentry fromtypescript-sdk/package.jsonand normalized the devDependency to a single entry (@types/node:^22.7.5).typescript-sdk/package-lock.jsonto match the manifest.json.loads(...)results todict[str, Any]inpython-sdk/tests/parity_report.py,python-sdk/tests/test_public_api.py, andpython-sdk/tests/test_verification.pyto satisfyruffandmypywithout altering behavior.typescript-sdk/package.json,typescript-sdk/package-lock.json,python-sdk/tests/parity_report.py,python-sdk/tests/test_public_api.py,python-sdk/tests/test_verification.py.Testing
cd python-sdk && ruff check .— PASS.cd python-sdk && mypy .— PASS.cd python-sdk && pytest— PASS (23 tests, 1 warning).cd typescript-sdk && npm ci— FAIL due to environment package acquisition (devDependencies could not be installed in this environment), blocking further TS install-dependent gates.cd typescript-sdk && npm run typecheck— FAIL because@types/nodeand other devDependencies were not installed fromnpm ci.cd typescript-sdk && npm test— FAIL becausetsup(devDependency) is not installed whennpm cicannot complete.cd typescript-sdk && npm pack --dry-run— FAIL because theprepackbuild step cannot run without installed devDependencies.cd python-sdk && python -m build— FAIL becausebuildtooling was not available in the environment andpip installwas not possible here.cd python-sdk && twine check dist/*— FAIL becausetwinewas not available in the environment.Note: All source fixes described above were applied and validated locally where possible; remaining failing gates are due to missing external tooling or blocked package acquisition in the execution environment and not due to source defects introduced by these edits.
Codex Task