Skip to content

Fix duplicate @types/node in TS manifest and address Python test lint/type issues#17

Merged
GsCommand merged 1 commit intomainfrom
codex/fix-phase-2-release-blocker-issues
Mar 21, 2026
Merged

Fix duplicate @types/node in TS manifest and address Python test lint/type issues#17
GsCommand merged 1 commit intomainfrom
codex/fix-phase-2-release-blocker-issues

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

  • Ensure the repository can pass Phase 2 gates by removing manifest drift in the TypeScript package metadata and clearing Python lint/type failures that block ruff/mypy/pytest validation.
  • Make the minimal, surgical edits required to restore internal coherence around v1.1.0 without changing public API or upgrading unrelated dependencies.

Description

  • Removed the duplicate/conflicting @types/node entry from typescript-sdk/package.json and normalized the devDependency to a single entry (@types/node: ^22.7.5).
  • Synchronized the root devDependencies entry in typescript-sdk/package-lock.json to match the manifest.
  • Fixed Python test lint and typing issues by reformatting a long import line, wrapping a long assertion, and casting json.loads(...) results to dict[str, Any] in python-sdk/tests/parity_report.py, python-sdk/tests/test_public_api.py, and python-sdk/tests/test_verification.py to satisfy ruff and mypy without altering behavior.
  • Files changed: typescript-sdk/package.json, typescript-sdk/package-lock.json, python-sdk/tests/parity_report.py, python-sdk/tests/test_public_api.py, python-sdk/tests/test_verification.py.

Testing

  • cd python-sdk && ruff check . — PASS.
  • cd python-sdk && mypy . — PASS.
  • cd python-sdk && pytest — PASS (23 tests, 1 warning).
  • cd typescript-sdk && npm ci — FAIL due to environment package acquisition (devDependencies could not be installed in this environment), blocking further TS install-dependent gates.
  • cd typescript-sdk && npm run typecheck — FAIL because @types/node and other devDependencies were not installed from npm ci.
  • cd typescript-sdk && npm test — FAIL because tsup (devDependency) is not installed when npm ci cannot complete.
  • cd typescript-sdk && npm pack --dry-run — FAIL because the prepack build step cannot run without installed devDependencies.
  • cd python-sdk && python -m build — FAIL because build tooling was not available in the environment and pip install was not possible here.
  • cd python-sdk && twine check dist/* — FAIL because twine was not available in the environment.

Note: All source fixes described above were applied and validated locally where possible; remaining failing gates are due to missing external tooling or blocked package acquisition in the execution environment and not due to source defects introduced by these edits.


Codex Task

@GsCommand GsCommand merged commit 0daa1f6 into main Mar 21, 2026
8 of 10 checks passed
@GsCommand GsCommand deleted the codex/fix-phase-2-release-blocker-issues branch April 24, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant