Skip to content

docs: correct receipt_wrong_kid behavior, align test refs to v1.1.0, improve v1.1.0 changelog#16

Merged
GsCommand merged 1 commit intomainfrom
codex/fix-phase-1-release-readiness-issues
Mar 21, 2026
Merged

docs: correct receipt_wrong_kid behavior, align test refs to v1.1.0, improve v1.1.0 changelog#16
GsCommand merged 1 commit intomainfrom
codex/fix-phase-1-release-readiness-issues

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

  • The test-vector documentation incorrectly implied receipt_wrong_kid.json could still verify with an explicit public key, which conflicts with the manifest and tests.
  • Several embedded examples still referenced 1.0.0, creating version-drift against the repo's canonical 1.1.0 line.
  • The v1.1.0 changelog entry was terse and did not clearly communicate breaking vs non-breaking changes, removals, or scope limits.

Description

  • Updated test_vectors/README.md so receipt_wrong_kid.json explicitly states it is expected to fail verification after a kid mutation changes the signed content.
  • Replaced obsolete 1.0.0 example values with 1.1.0 in typescript-sdk/scripts/unit-tests.mjs to keep runtime examples coherent with the active Commons surface.
  • Replaced the same 1.0.0 example values with 1.1.0 in python-sdk/tests/test_verify.py so the signed-receipt helper matches the repo's canonical version.
  • Expanded and rewritten the v1.1.0 entry in CHANGELOG.md to describe what changed from 1.0.0, what was removed (including that Commons is no longer x402-first), breaking vs non-breaking changes, and known limitations/scope.

Testing

  • Ran pytest -q python-sdk/tests/test_verify.py, which completed successfully.
  • Attempted node typescript-sdk/scripts/unit-tests.mjs in this environment but it failed to start due to a missing local Node dependency (ethers), which is an environment setup issue and not caused by these edits.

Codex Task

@GsCommand GsCommand merged commit af7f511 into main Mar 21, 2026
0 of 10 checks passed
@GsCommand GsCommand deleted the codex/fix-phase-1-release-readiness-issues branch April 24, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant