Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
receipt_wrong_kid.jsoncould still verify with an explicit public key, which conflicts with the manifest and tests.1.0.0, creating version-drift against the repo's canonical1.1.0line.v1.1.0changelog entry was terse and did not clearly communicate breaking vs non-breaking changes, removals, or scope limits.Description
test_vectors/README.mdsoreceipt_wrong_kid.jsonexplicitly states it is expected to fail verification after akidmutation changes the signed content.1.0.0example values with1.1.0intypescript-sdk/scripts/unit-tests.mjsto keep runtime examples coherent with the active Commons surface.1.0.0example values with1.1.0inpython-sdk/tests/test_verify.pyso the signed-receipt helper matches the repo's canonical version.v1.1.0entry inCHANGELOG.mdto describe what changed from1.0.0, what was removed (including that Commons is no longer x402-first), breaking vs non-breaking changes, and known limitations/scope.Testing
pytest -q python-sdk/tests/test_verify.py, which completed successfully.node typescript-sdk/scripts/unit-tests.mjsin this environment but it failed to start due to a missing local Node dependency (ethers), which is an environment setup issue and not caused by these edits.Codex Task