Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DEVELOPER_EXPERIENCE.md→MAINTAINER_GUIDE.mdandDEPLOYMENT_GUIDE.md→RELEASE_GUIDE.md, and rewrote the first paragraph of each to state the intended audience and who they are not for.CONTRIBUTING.md,VERSIONING.md, and a rootpackage.jsonwithtest:fullto document and script build/test ordering for runtime tests..github/workflows/release.ymlto run TS + Python CI, build artifacts, validate packages, and publish on tag/release events.public_key_v1_base64.txt,public_key_v2_base64.txt,receipt_valid_v1.json,receipt_valid_v2.json,receipt_removed_kid.json, andtest_vectors/README.md; removed the oldreceipt_malformed_pubkey.json.kidin TypeScript (resolveSignerKeynow acceptsrequestedKid) and mirrored the behavior in Python, and updated helpers and runtime tests to exercise v1-after-v2, v2-current, wrong kid, and removed kid cases.call, andverifyinput expectations).Testing
npm install→npm run build→npm run testsucceeded (TS unit/tests + template subtests passed, CLI smoke adjusted and passed).npm run test:fullsucceeded, exercising the updated ENS rotation tests (runtime tests passed).cd python-sdk && pytestsucceeded (all Python verification tests passed).python -m buildandpython -m twine check dist/*) could not be executed in this environment due to missingbuild/twinemodules, so PyPI artifact validation remains to be exercised in CI.Codex Task